Skip to content

Should the logo have a white background? #339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
spenserblack opened this issue Dec 9, 2020 · 2 comments
Closed

Should the logo have a white background? #339

spenserblack opened this issue Dec 9, 2020 · 2 comments
Assignees
@o2sh
Labels
discussion good first issue Good for newcomers Type: Question Further information is requested

Comments

@spenserblack
Copy link
Collaborator

GitHub now has an official dark theme. When using the dark theme, onefetch.svg's text is hard to read due to the low contrast between the black text and the dark (#30363d if I'm reading the CSS correctly) rendered README background.
@spenserblack spenserblack added good first issue Good for newcomers Type: Question Further information is requested discussion labels Dec 9, 2020
@o2sh o2sh self-assigned this Dec 9, 2020
o2sh added a commit that referenced this issue Dec 10, 2020
@o2sh
add white border to onefetch logo #339
1c96eef
o2sh added a commit that referenced this issue Dec 10, 2020
@o2sh
add white border to onefetch logo #339
2e466b9
o2sh added a commit that referenced this issue Dec 10, 2020
@o2sh
brighter onefetch logo #339
a368af8
o2sh added a commit that referenced this issue Dec 10, 2020
@o2sh
even brighter onefetch logo #339
58a2cbb
@o2sh
Copy link
Owner

o2sh commented Dec 10, 2020

The "least" ugly solution I found was to make the logo a little brighter (black --> dark grey).

o2sh added a commit that referenced this issue Dec 10, 2020
@o2sh
little darker onefetch logo #339
224965a
@spenserblack
Copy link
Collaborator Author

spenserblack commented Dec 10, 2020 •
edited
Loading

Still looks readable on light background, but is now more readable on dark background 😄

It still looks better on a light background IMO, but I think that's about as good as we're going to get 🙂

@o2sh o2sh closed this as completed Dec 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@o2sh o2sh

Labels
discussion good first issue Good for newcomers Type: Question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@spenserblack @o2sh