Skip to content

Limit shown languages to 6 #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 27, 2019
Merged

Limit shown languages to 6 #114

merged 4 commits into from
Oct 27, 2019

Conversation

shuni64
Copy link
Contributor

@shuni64 shuni64 commented Oct 26, 2019

Closes #112

@shuni64 shuni64 changed the title Limit lang Limit shown languages to 6 Oct 26, 2019
@o2sh
Copy link
Owner

o2sh commented Oct 26, 2019

Great job @CephalonRho ,
However the Other stat should always be printed at last, which is not the case when the cumulated percentage of remaining languages is not the smallest:

DeepinScreenshot_select-area_20191026234855

Looking forward to merge your PR 👍

@shuni64
Copy link
Contributor Author

shuni64 commented Oct 27, 2019

I removed the second sort, now it should always be printed last.
image
I first added it because I thought that it would represent repositories with a large variety of languages better, but this is fine too.

@o2sh
Copy link
Owner

o2sh commented Oct 27, 2019

DeepinScreenshot_select-area_20191027125058

Other than that, LGTM 🥇

@shuni64
Copy link
Contributor Author

shuni64 commented Oct 27, 2019

Sorry, missed the warning. Should be fine now.

@o2sh o2sh merged commit 08d9130 into o2sh:master Oct 27, 2019
@shuni64 shuni64 deleted the limit-lang branch October 27, 2019 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Limt the number of language statistics
2 participants
@shuni64 @o2sh