Skip to content

Feature/no merges #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 31, 2019
Merged

Feature/no merges #141

merged 4 commits into from
Oct 31, 2019

Conversation

spenserblack
Copy link
Collaborator

Resolves #131
Let me know if I missed anything!

@spenserblack spenserblack requested a review from o2sh October 31, 2019 15:02
o2sh
o2sh requested changes Oct 31, 2019
View reviewed changes
Copy link
Owner

@o2sh o2sh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👍 , If you could just add a .short("n") as a shortcut for --no-merges

@spenserblack
Copy link
Collaborator Author

👍, but are we sure -n should be used for this? There's already a "no" flag (-n, --no-bold). How about .short("m")?

@o2sh
Copy link
Owner

o2sh commented Oct 31, 2019

You're absolutely right, it's more consistent that way 👍

@spenserblack
Copy link
Collaborator Author

Done 😃

@o2sh o2sh merged commit 654a726 into master Oct 31, 2019
@spenserblack spenserblack deleted the feature/no-merges branch October 31, 2019 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@o2sh o2sh o2sh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Onefetch counts Merge Commits
2 participants
@spenserblack @o2sh