Skip to content

ASCII Jupyter logo, Fixes #219 #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 6, 2020
Merged

ASCII Jupyter logo, Fixes #219 #231

merged 4 commits into from
Oct 6, 2020

Conversation

maash3r
Copy link
Contributor

@maash3r maash3r commented Oct 6, 2020

Changed the ASCII logo for Jupyter and updated the language.rs for color scheme.

@maash3r maash3r closed this Oct 6, 2020
@maash3r maash3r reopened this Oct 6, 2020
@o2sh
Copy link
Owner

o2sh commented Oct 6, 2020

Great Work @maash3r
However, as most people use terminals with black background. The black spheres won't show. I'd advise to switch to another color.
Even though it means drifting away from the original design of the logo.

Looking forward to merge your PR

@maash3r
Copy link
Contributor Author

maash3r commented Oct 6, 2020

I saw some of the logos using black so thought it would work. Changed it to blue now.

@o2sh
Copy link
Owner

o2sh commented Oct 6, 2020

I saw some of the logos using black so thought it would work.

These logos use the color black as an alternative to blank spaces.

Anyway, thanks a lot for this PR @maash3r

@o2sh o2sh merged commit db92791 into o2sh:master Oct 6, 2020
@maash3r maash3r deleted the ascii/jupyter branch October 9, 2020 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants