return Err when image but no image backend #289
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I removed the
panic!("No image backend found")
from Info.fmt() and I added a check in case the user chose an image-backend not supported by his terminal.By the way, I noticed that
kitty::KittyBackend::supported()
andsixel::SixelBackend::supported()
need toprintln!()
a sequence of characters in order to check if the corresponding backend is supported, resulting in two empty lines if both check fail:I tried wrapping both methods into smth like (+ replace println! by print!):
but it broke everything 😭