Skip to content

Ascii script #293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 25, 2020
Merged

Ascii script #293

merged 3 commits into from
Oct 25, 2020

Conversation

geeseven
Copy link
Contributor

I made some improvements to the python script that converts images to ASCII art from the wiki.

See #280

@geeseven
Copy link
Contributor Author

Seeing that I missed an end quote, feel free to squash when merging.

@o2sh
Copy link
Owner

o2sh commented Oct 25, 2020

Thanks a lot for your PR @geeseven
However, I don't see the point in updating the script if the old version is still being referenced in the wiki.

@geeseven
Copy link
Contributor Author

Hey @o2sh,

You want the wiki to get updated before merging this Pull Request?

@o2sh o2sh merged commit 1e29965 into o2sh:master Oct 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@geeseven @o2sh