Skip to content

Added HolyC support #313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 14, 2020
Merged

Added HolyC support #313

merged 6 commits into from
Nov 14, 2020

Conversation

Ferryistaken
Copy link
Contributor

The logo is just like the C logo but with a cross, and with TempleOS colors

@Ferryistaken Ferryistaken mentioned this pull request Nov 8, 2020
o2sh added a commit that referenced this pull request Nov 8, 2020
@o2sh
Copy link
Owner

o2sh commented Nov 8, 2020

Thanks for your PR @Ferryistaken
Still, your design feels kinda uninspired.

Maybe try working with this one:

holyc

Looking forward to merge your PR 💯

@Ferryistaken
Copy link
Contributor Author

Ferryistaken commented Nov 8, 2020

Ok I'll work on that! I saw the one you sent while searching for a holyc logo but I liked the one with the cross better

@Ferryistaken
Copy link
Contributor Author

New logo is here! Here is how it looks with my terminal colorscheme:
https://imgur.com/a/FXn8gDD

The color of the cirle on top is yellow, the top part of the C logo is cyan, and the bottom is Blue

@Ferryistaken
Copy link
Contributor Author

Nevermind by taking the picture I realized that now that I added the colors it's not centered anymore. I'm gonna work on that now

@Ferryistaken
Copy link
Contributor Author

The CI/CD build fails, but it compiles perfectly on my Arch Linux system?

@o2sh
Copy link
Owner

o2sh commented Nov 9, 2020

The CI/CD build fails, but it compiles perfectly on my Arch Linux system?

It compiles but if fails the integration tests:

 ---- onefetch::language::ascii_size::holyc_height stdout ----
thread 'onefetch::language::ascii_size::holyc_height' panicked at 'assertion failed: `(left <= right)`
  left: `28`,
 right: `25`: holyc.ascii is too tall.', src/onefetch/language.rs:166:1

Which means that your logo exceeds the max-height by 3. Indeed, from CONTRIBUTING.md:

  • Your ascii logo's dimensions must fall below 25x40. The CI will fail otherwise.

@Ferryistaken
Copy link
Contributor Author

Ok I'll try and create a new one when I have time but as you have probably figured out making ascii logos isn't the thing i'm best at(nor something that I really like doing)

@o2sh
Copy link
Owner

o2sh commented Nov 9, 2020

Ok I'll try and create a new one when I have time but as you have probably figured out making ascii logos isn't the thing i'm best at(nor something that I really like doing)

I agree, it can be quite frustrating after a while. But you're very close, try using the python tool to generate a smaller C logo.

@Ferryistaken
Copy link
Contributor Author

Will do thanks for the pointer

@FlexCode29
Copy link

Immediately merge u heretic freaks

@o2sh
Copy link
Owner

o2sh commented Nov 10, 2020

Immediately merge u heretic freaks

The day of merge has been announced and it will come 🙌 . But the day has not come yet.

...soon 🙏

@willow385
Copy link

Why not just use the TempleOS logo?

Something like this:
image

Or this:
image

but asciified?

@o2sh
Copy link
Owner

o2sh commented Nov 12, 2020

I don't think we should confuse the programming language with the operating system. The TempleOS ASCII logo would be relevant in regard to Neofetch, not Onefetch.

@Ferryistaken
Copy link
Contributor Author

Well AFAIK there is not official Holy C logo, so he isn't wrong

@o2sh
Copy link
Owner

o2sh commented Nov 12, 2020

Ok, I surrender. @Ferryistaken feel free to switch to the TempleOS design if you prefer.

@Ferryistaken
Copy link
Contributor Author

I like the one you proposed more, I was just saying that since there is no official logo it technically wouldn't be wrong to use the TempleOS logo. BTW I think that I will have time this weekend, so at most the pull request will be ready for sunday

@Ferryistaken
Copy link
Contributor Author

The only change that I would make now is maybe make the C part of the logo look more like the resources/c.ascii logo, but I like the more "rough" aesthetic, I think it fits the language(and templeOS)

@o2sh
Copy link
Owner

o2sh commented Nov 14, 2020

Thanks for you PR @Ferryistaken, I cleaned it a bit:

holyc

@o2sh o2sh merged commit 0af1dcf into o2sh:master Nov 14, 2020
@Ferryistaken
Copy link
Contributor Author

Looks very nice! Sorry that you couldn't use my design and that this whole PR was a bit useless, I'll try and do better if I'll ever add new languages!

@o2sh
Copy link
Owner

o2sh commented Nov 14, 2020

Final version:

holyc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants