-
Notifications
You must be signed in to change notification settings - Fork 286
Added HolyC support #313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added HolyC support #313
Conversation
Thanks for your PR @Ferryistaken Maybe try working with this one: Looking forward to merge your PR 💯 |
Ok I'll work on that! I saw the one you sent while searching for a holyc logo but I liked the one with the cross better |
New logo is here! Here is how it looks with my terminal colorscheme: The color of the cirle on top is yellow, the top part of the C logo is cyan, and the bottom is Blue |
Nevermind by taking the picture I realized that now that I added the colors it's not centered anymore. I'm gonna work on that now |
The CI/CD build fails, but it compiles perfectly on my Arch Linux system? |
It compiles but if fails the integration tests:
Which means that your logo exceeds the max-height by 3. Indeed, from CONTRIBUTING.md:
|
Ok I'll try and create a new one when I have time but as you have probably figured out making ascii logos isn't the thing i'm best at(nor something that I really like doing) |
I agree, it can be quite frustrating after a while. But you're very close, try using the python tool to generate a smaller C logo. |
Will do thanks for the pointer |
Immediately merge u heretic freaks |
The day of merge has been announced and it will come 🙌 . But the day has not come yet. ...soon 🙏 |
I don't think we should confuse the programming language with the operating system. The TempleOS ASCII logo would be relevant in regard to Neofetch, not Onefetch. |
Well AFAIK there is not official Holy C logo, so he isn't wrong |
Ok, I surrender. @Ferryistaken feel free to switch to the TempleOS design if you prefer. |
I like the one you proposed more, I was just saying that since there is no official logo it technically wouldn't be wrong to use the TempleOS logo. BTW I think that I will have time this weekend, so at most the pull request will be ready for sunday |
The only change that I would make now is maybe make the C part of the logo look more like the |
Thanks for you PR @Ferryistaken, I cleaned it a bit: |
Looks very nice! Sorry that you couldn't use my design and that this whole PR was a bit useless, I'll try and do better if I'll ever add new languages! |
The logo is just like the C logo but with a cross, and with TempleOS colors