Skip to content

Add CLI option to switch true colors on/off #373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 13, 2021
Merged

Add CLI option to switch true colors on/off #373

merged 2 commits into from
Jan 13, 2021

Conversation

spenserblack
Copy link
Collaborator

Allows user to control if onefetch should attempt to write true colors to the terminal.


I found myself wanting to turn off true colors when executing onefetch so that the output would match my preferred color scheme, and figured that other users might want to do the same 🙂

Allows user to control if onefetch should attempt to write true colors
to the terminal.
@spenserblack spenserblack added the enhancement New feature or request label Jan 12, 2021
@spenserblack spenserblack requested a review from o2sh January 12, 2021 19:03
Copy link
Owner

@o2sh o2sh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're absolutely right, for those who like to play with their terminal's color scheme, this flag can come to be very handy.

My only suggestion would be to use --show-logo as a template for its declaration as the two flags seem to operate similarly.

@spenserblack
Copy link
Collaborator Author

My only suggestion would be to use --show-logo as a template

Nice catch! The args should definitely have consistent usage. Suggestions committed.

@o2sh o2sh merged commit 503d82f into o2sh:master Jan 13, 2021
@spenserblack spenserblack deleted the feature/cli/truecolor-control branch January 13, 2021 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants