Skip to content

ignore bots in commits #448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 25, 2021
Merged

ignore bots in commits #448

merged 3 commits into from
Jun 25, 2021

Conversation

o2sh
Copy link
Owner

@o2sh o2sh commented Jun 24, 2021

closes #446

@o2sh o2sh requested a review from spenserblack June 24, 2021 23:22
Copy link
Collaborator

@spenserblack spenserblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a slight concern about a possible panic, but overall LGTM! 🎉

- validator for regex pattern provided to no-bots flag
- switch type of bot_exclude_pattern to prevent multiple regex compilation
- improve syntax for no-bots cli flag
Copy link
Collaborator

@spenserblack spenserblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@o2sh o2sh merged commit a611fe4 into master Jun 25, 2021
@o2sh o2sh deleted the feature/ignore-bot-commits branch June 25, 2021 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ignore [bot] commits 🤖🤖
2 participants