Skip to content

add support for powershell #454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 1, 2021
Merged

add support for powershell #454

merged 4 commits into from
Jul 1, 2021

Conversation

dxking
Copy link
Contributor

@dxking dxking commented Jul 1, 2021

This pull request adds support for PowerShell.

Logo was derived and modified from the existing zsh.ascii file. I'm not totally in love with the ASCII art but can't quite pin down what could improve it.

@spenserblack
Copy link
Collaborator

spenserblack commented Jul 1, 2021

🤔 Perhaps you could use white text for the >_ to make it a bit more distinct from onefetch's zsh logo and closer to the official PowerShell logo. What do you think?

@dxking
Copy link
Contributor Author

dxking commented Jul 1, 2021

@spenserblack I made some changes to powershell.ascii to add white for the >_ and switched up the characters being used (nothing really seemed to go well with # that was being used for the background). I think it looks a bit better now.
image

@o2sh
Copy link
Owner

o2sh commented Jul 1, 2021

To be even closer to the original design, we may want to "lean" toward smth like that:

2021-07-01_22-48

{0}         ########################
{0}        ####{1}####{0}################
{0}       ######{1}####{0}##############
{0}      ########{1}####{0}############
{0}     ##########{1}####{0}##########
{0}    #########{1}####{0}###########
{0}   ########{1}####{0}############
{0}  #######{1}####{0}#############
{0} ######{1}####{0}#####{1}######{0}###
{0}########################

What do you think @dxking ?

@dxking
Copy link
Contributor Author

dxking commented Jul 1, 2021

@o2sh Yeah, that looks great! I can get powershell.ascii updated with that design, thanks!

@dxking
Copy link
Contributor Author

dxking commented Jul 1, 2021

Updated to use your suggested ASCII art.

@o2sh o2sh merged commit 5244828 into o2sh:main Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants