Move all ascii art to separate files #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is similar to other language matching functions. This keeps the ascii art more organized, and its easier to add more languages without bloating main.rs
|
Are you sure the added IO overhead resulting from reading a file from disk is worth it ? |
|
This does not read from file when running, only at build time. What I think would be even better, is to have some configuration for every file, where you would specify what color to use and what ascii art to use. |
|
Ok, I will merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is similar to other language matching functions.
This keeps the ascii art more organized, and its easier to add more languages without bloating main.rs