Skip to content

feat: support AutoHotKey #508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 17, 2021
Merged

feat: support AutoHotKey #508

merged 3 commits into from
Oct 17, 2021

Conversation

PurpleMyst
Copy link
Contributor

No description provided.

@o2sh
Copy link
Owner

o2sh commented Oct 17, 2021

Thanks for your contribution @PurpleMyst
Can you tell us on what image is your ASCII logo based on ?

The only logo I could find for Auto Hot Key is:

1200px-Modern_AutoHotkey_Logo_(no_text) svg

spenserblack
spenserblack reviewed Oct 17, 2021
View reviewed changes
Copy link
Collaborator

@spenserblack spenserblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR!
I'm worried that white text might be a little plain. I noticed that AutoHotkey sometimes has a green box containing a white H for its logo. What do you think about that?

@PurpleMyst
Copy link
Contributor Author

PurpleMyst commented Oct 17, 2021 •
edited
Loading

Would you like more that we make the logo just an H in a green box or that we keep the same logo shape but make its H green?

@PurpleMyst
Copy link
Contributor Author

Thanks for your contribution @PurpleMyst Can you tell us on what image is your ASCII logo based on ?

The only logo I could find for Auto Hot Key is:

1200px-Modern_AutoHotkey_Logo_(no_text) svg

I did find that logo, but it does not translate well to ascii art sadly

@PurpleMyst
Copy link
Contributor Author

I've changed to just the H in a box. LMK what you think!

spenserblack
spenserblack approved these changes Oct 17, 2021
View reviewed changes
Copy link
Collaborator

@spenserblack spenserblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't run it, but based on looking at the code LGTM

@o2sh o2sh merged commit be7787e into o2sh:main Oct 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spenserblack spenserblack spenserblack approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PurpleMyst @o2sh @spenserblack