Add workflow for Minimum Rust Version badge #527
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To be able to see what's going on in the repo for possible debugging.
Agreed 👍 If the PR is good for you I'll let you trigger the workflow to generate a new badge before merging. |
|
Changes look good! My only change after those was changing the literal |
`paths` is only valid for `push` or `pull_request`. https://docs.github.com/en/actions/learn-github-actions/workflow-syntax-for-github-actions#onpushpull_requestpaths
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #525
This CI is very slow, taking about 15 minutes to complete. To help reduced conflicts, I added a
git pullto the script that commits the badge.However, this slowness might be something to consider for the workflow triggers. Perhaps the trigger should be on release instead?