Skip to content

Refactoring #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
5 tasks done
vaind opened this issue Sep 11, 2019 · 0 comments
Closed
5 tasks done

Refactoring #19

vaind opened this issue Sep 11, 2019 · 0 comments
Labels
good first issue Good for newcomers help wanted Looking for contributors (ideas, comments, code, etc)
Milestone
0.3

Comments

@vaind
Copy link
Contributor

vaind commented Sep 11, 2019 •
edited by nalenz-objectbox
Loading

  • move common.lastErrorString to binding/helpers.dart - it's the only place where it's called from
  • since generated "flatbuffers_id": ${(prop['id'] as int) - 1}, is always property.Id - 1 it can be removed completely (as in other language bindings)
  • remove box.close() - that's not how a store should be closed
  • split flatbuffers marshalling out of box.dart
  • use dartfmt -l 120 (and add it to contribution guide?)
@vaind vaind added this to the 0.3 milestone Sep 12, 2019
@vaind vaind added good first issue Good for newcomers help wanted Looking for contributors (ideas, comments, code, etc) labels Sep 12, 2019
@nalenz-objectbox nalenz-objectbox mentioned this issue Sep 16, 2019
Merged
@vaind vaind closed this as completed Sep 16, 2019
@FredJul FredJul mentioned this issue Sep 22, 2021
Closed
greenrobot-team added a commit that referenced this issue May 3, 2022
@greenrobot-team
Demo: note why closure is not used for run async (#19)
70cc9dd
greenrobot-team added a commit that referenced this issue May 10, 2022
@greenrobot-team
Merge branch '19-run-in-tx-async' into 'main'
37f8089 
Add async variant of runInTransaction

Closes #19

See merge request objectbox/objectbox-dart!5
greenrobot-team added a commit that referenced this issue Jun 1, 2022
@greenrobot-team
Benchmark: compare runInTransaction against runInTransactionAsync (#19)
8e0021a
greenrobot-team added a commit that referenced this issue Jun 1, 2022
@greenrobot-team
Benchmark: cache Box for runInTransactionAsync (#19)
cee3345
greenrobot-team added a commit that referenced this issue Jun 1, 2022
@greenrobot-team
Benchmark: runAsync, also return values from transaction (#19)
561baea
greenrobot-team added a commit that referenced this issue Jun 1, 2022
@greenrobot-team
Benchmark: test store open (#19)
a6fa9cc
@ProyekRiad ProyekRiad mentioned this issue Aug 23, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Looking for contributors (ideas, comments, code, etc)
Projects
None yet
Milestone
0.3
Development

No branches or pull requests
1 participant
@vaind