Skip to content

Finalizers keep-alive #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 17, 2021
Merged

Finalizers keep-alive #243

merged 1 commit into from
May 17, 2021

Conversation

vaind
Copy link
Contributor

@vaind vaind commented May 17, 2021

query and property query - add a reachabilityFence() after each use of a native pointer with a finalizer attached to prevent premature finalization.

@vaind vaind requested a review from greenrobot-team May 17, 2021 11:25
Copy link
Member

@greenrobot-team greenrobot-team left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Likely needs updating to match updated recommendation.

Otherwise gnawing my teeth at this, but if finalizers should be in 1.0 I understand this needs to happen.

@vaind vaind force-pushed the finalizers-keepalive branch from 7970baa to 3abe814 Compare May 17, 2021 13:54
… of a native pointer with a finalizer attached to prevent premature finalization.
@vaind vaind force-pushed the finalizers-keepalive branch from 3abe814 to 2694cbd Compare May 17, 2021 13:55
@vaind vaind merged commit 835c59a into main May 17, 2021
@vaind vaind deleted the finalizers-keepalive branch May 17, 2021 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants