On iOS use Dart API instead of memcpy #333
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greenrobot
reviewed
Nov 2, 2021
| /// so use Dart API to copy data via asTypedList (which is much slower but works). | ||
| /// | ||
| /// https://github.com/objectbox/objectbox-dart/issues/313 | ||
| final isMemcpyNotAvailable = Platform.isIOS; |
There was a problem hiding this comment.
can we instead catch the error of _stdlib.lookupFunction() below? Would have a couple of advantages?
There was a problem hiding this comment.
Yeap, makes more sense, changed!
There was a problem hiding this comment.
Verified to work on iOS 15 simulator using example app.
greenrobot-team
force-pushed
the
gh-313-memcpy-ios-workaround
branch
from
e5a442c to
658e837
Compare
greenrobot
approved these changes
Nov 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workaround for #313
If lookup of native memcpy function fails use a Dart implementation instead.
Except in case of
ReaderWithCBufferwhere a somewhat faster fallback implementation already exists (in case its shared buffer is too small it creates a new buffer and returns a view of it).To avoid the performance penalty on real devices might detect the iOS simulator. But this seems only possible using a Flutter plugin (based on an Apple flag available at compile time, e.g. see the Flutter device_info_plus plugin).