Skip to content

Add an option to configure generator's output_dir #341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 30, 2021

Conversation

vaind
Copy link
Contributor

@vaind vaind commented Nov 28, 2021

closes #312

  • Check failed test: custom directory needs to exist.
  • Imports in generated code are wrong (assumes generated code file is in top-most directory).
  • Add documentation.
  • Clean up integration test (currently just copy/paste from final test).

Copy link
Member

@greenrobot-team greenrobot-team left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
Changed to prefix imports with one or more ../ to fix imports in generated code file.
Fixed imports in test, reduced to minimal required.
Added documentation.
@vaind Maybe have a look at the import changes, can you think of a better solution?

@vaind
Copy link
Contributor Author

vaind commented Nov 29, 2021

Maybe have a look at the import changes, can you think of a better solution?

LGTM. I've made a minor change - not sure it's needed but doesn't hurt anything I guess

@greenrobot-team greenrobot-team added this to the 1.4 milestone Nov 30, 2021
@greenrobot-team greenrobot-team merged commit 3c34e8c into main Nov 30, 2021
@greenrobot-team greenrobot-team deleted the 312-generator-config branch November 30, 2021 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow declaring directory for generated files
2 participants