Skip to content

Add Store.attach. #376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 22, 2022
Merged

Add Store.attach. #376

merged 2 commits into from
Feb 22, 2022

Conversation

greenrobot-team
Copy link
Member

@greenrobot-team greenrobot-team commented Jan 31, 2022

Copy link
Member

@greenrobot greenrobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; please merge after changes

@greenrobot-team
Copy link
Member Author

greenrobot-team commented Feb 7, 2022

From stand-up: change to not allow using Store.attach with store already opened in same isolate (re-add dbDir check). This is to prevent incorrect usage (e.g. opening transactions in both stores at the same time is not possible).

@greenrobot-team greenrobot-team merged commit 183aade into main Feb 22, 2022
@greenrobot-team greenrobot-team deleted the store-attach branch February 22, 2022 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants