Model generator issues & improvements #74
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vaind
force-pushed
the
56-generated-model
branch
from
a0868e0 to
8f836ae
Compare
vaind
changed the title
greenrobot-team
added a commit
that referenced
this pull request
Jul 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves various aspects of the generator and the generated code as well as fixes some issues with how model is built in ObjectBox core (last-...-id)
Fixes #56
Though it still uses the JSON to limit the amount of generator and model code we have to maintain, it now does load it entity by entity, so the code is cleaner.
Fixes #38
One can now use
GENERATOR=update-expected pub run testin the generator directory to update the expected test files.Fixes #40
Non-issue but I've added a test case to cover a potential regression in the future.
From #55
The generator already handled multiple files (added a test case for that). However, it didn't create a single "ModelInfo" so user can't really load them properly. There's a follow up PR with major generator changes fixing this issue: #76