Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
explicit facet option in a mark #450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
explicit facet option in a mark #450
Changes from 3 commits
8c303b1
355d585
9fd5aff
9d75322
674e246
576f338
166af6d
a192d35
9b0b13b
84ec124
753b142
f14dabc
ecc7abb
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should do some validation and coercion here.
I also think we can unify the types a little more. Currently:
"exclude"
is a string,null
andundefined
are equivalent, andtrue
andfalse
are booleans.If we want to be more analogous to the scale.axis option, perhaps:
"exclude"
"include"
, andtrue
is shorthand for"include"
undefined
is"include"
if data is strict equal, and otherwisenull
to disable facetingnull
or any other falsey value is mapped tonull
to disable facetingAny other truthy value, after being coerced to a string, would throw an error. We’d use the
keyword
helper:plot/src/mark.js
Line 126 in 068f8d8