Add query and query_range as generic handlers forwarding all verbs #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squat
approved these changes
Apr 23, 2020
|
(Background: clusters-service, which is one of the backends of OCM, is doing POST to /api/v1/query to avoid query length limits. |
|
That's good insight to why a POST makes more sense than a GET. I was already wondering why you want POST :) |
periklis
pushed a commit
to periklis/api
that referenced
this pull request
Jul 9, 2021
environments: fix statefulset servicename
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Next to adding the
/api/v1/query_rangeendpoint too, the handlers are now simple handlers accepting every verb and then letting the downstream service decide on accepting or declining requests with specific verbs./cc @squat @kakkoyun @brancz