Skip to content

Fix unboxed primitives test #1642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 25, 2023
Merged

Fix unboxed primitives test #1642

merged 3 commits into from
Jul 25, 2023

Conversation

TheNumbat
Copy link
Contributor

@TheNumbat TheNumbat commented Jul 25, 2023

Running unboxed-primitive-args/test.ml locally with make test-one ends up compiling it in a different working directory, so this PR removes the hardcoded include path for gcc.

Also, compiling the test with closure can run into stack limits (also only locally, seems not to in the CI), so this reduces the number of generated functions from 5^6 to 5^5.

Copy link
Contributor

@ccasin ccasin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested locally and confirmed this fixes my build issues.

I guess it's slightly sad to generate fewer test cases. In the future we could consider the generated code into multiple files.

@TheNumbat TheNumbat merged commit dd69ba4 into main Jul 25, 2023
@TheNumbat TheNumbat deleted the fix-unboxed-prim-test branch July 25, 2023 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants