Skip to content

Re-enable some tests that it seems should work now #2109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 4, 2023
Merged

Re-enable some tests that it seems should work now #2109

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions ocaml/testsuite/tests/c-api/test_c_thread_has_lock.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
(* TEST
modules = "test_c_thread_has_lock_cstubs.c"
* skip
reason = "OCaml 5 only"
* runtime5
** bytecode
** native
*)
Expand Down
3 changes: 1 addition & 2 deletions ocaml/testsuite/tests/c-api/test_c_thread_has_lock_systhread.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
(* TEST
modules = "test_c_thread_has_lock_cstubs.c"
* skip
reason = "OCaml 5 only"
* runtime5
** hassysthreads
include systhreads
*** bytecode
Expand Down
3 changes: 1 addition & 2 deletions ocaml/testsuite/tests/frame-pointers/c_call.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
(* TEST

* skip
reason = "OCaml 5 only"
* runtime5
** frame_pointers
*** native
readonly_files = "fp_backtrace.c c_call_.c"
Expand Down
3 changes: 1 addition & 2 deletions ocaml/testsuite/tests/frame-pointers/exception_handler.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
(* TEST

* skip
reason = "OCaml 5 only"
* runtime5
** frame_pointers
*** native
readonly_files = "fp_backtrace.c"
Expand Down
4 changes: 1 addition & 3 deletions ocaml/testsuite/tests/lazy/minor_major_force.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
(* TEST
ocamlopt_flags += " -O3 "

* skip
reason = "OCaml 5 only"
* runtime5
*)

(*
Expand Down
4 changes: 1 addition & 3 deletions ocaml/testsuite/tests/lf_skiplist/test.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
(* TEST
modules = "stubs.c"

* skip
reason = "OCaml 5 only"
* runtime5
*)

external test_skiplist_serial : unit -> unit = "test_skiplist_serial"
Expand Down
5 changes: 2 additions & 3 deletions ocaml/testsuite/tests/lib-channels/close_in.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
(* TEST
* skip
reason = "OCaml 5 only"
*)
* runtime5
*)

(* Test that inputting bytes from a closed in_channel triggers an exception *)

Expand Down
3 changes: 1 addition & 2 deletions ocaml/testsuite/tests/lib-random/testvectors.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
(* TEST
* skip
reason = "OCaml 5 only"
* runtime5
*)

(* Check the numbers drawn from a known state against the numbers
Expand Down
3 changes: 1 addition & 2 deletions ocaml/testsuite/tests/lib-sync/trylock.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
(* TEST
* skip
reason = "OCaml 5 only"
* runtime5
*)

(* Test Mutex.try_lock *)
Expand Down
3 changes: 1 addition & 2 deletions ocaml/testsuite/tests/lib-sync/trylock2.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
(* TEST
* skip
reason = "OCaml 5 only"
* runtime5
*)

(* Test Mutex.try_lock *)
Expand Down
3 changes: 1 addition & 2 deletions ocaml/testsuite/tests/lib-systhreads/boundscheck.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
(* TEST

include systhreads
* skip
reason = "OCaml 5 only"
* runtime5
** hassysthreads
*** bytecode
*** native
Expand Down
2 changes: 1 addition & 1 deletion ocaml/testsuite/tests/memory-model/forbidden.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
(* TEST
modules="opt.ml barrier.ml hist.ml shared.ml run.ml outcome.ml"
* skip
reason = "OCaml 5 only"
reason = "CR ocaml 5 domains: re-enable this test"
** not-bsd
*** bytecode
*** native
Expand Down