Skip to content

Fix simplification of never_return applications #2142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 13, 2023

Conversation

Ekdohibs
Copy link
Contributor

This case was not possible before, and therefore unimplemented.

@mshinwell mshinwell added the flambda2 Prerequisite for, or part of, flambda2 label Dec 11, 2023
@mshinwell
Copy link
Collaborator

@Gbury will review

Copy link
Contributor

@Gbury Gbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks correct.

It'd be better if we could avoid the code duplication between EB.rewrite_fixed_arity_apply and rebuild_function_call_where_callee's_type_unavailable though...

@Ekdohibs Ekdohibs merged commit cffb9cc into ocaml-flambda:main Dec 13, 2023
Ekdohibs added a commit to Ekdohibs/flambda-backend that referenced this pull request Dec 13, 2023
Ekdohibs added a commit that referenced this pull request Dec 13, 2023
Ekdohibs added a commit to Ekdohibs/flambda-backend that referenced this pull request Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flambda2 Prerequisite for, or part of, flambda2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants