Remove access to old size macros #2654
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stop allowing use of the
*size*
family of macros. User code should instead useAllocated_*size*
. This helps us be more confident that users will be notified if importing code that interprets a block's allocated size as its scannable size.There are two exceptions:
*size*
family of macros. This avoids some renaming churn in the compiler which could introduce the possibility of merge conflicts. A counterargument is: well, we should be confident that the compiler code has been vetted in the same way. (My preference is to rely on testing here.) I'm open to rethinking this, but my starting point is that it's better to avoid the merge conflicts.Once #2653 is merged and user code is updated, we can merge this.