Fix -stop-after lambda
#3128
Merged
Fix -stop-after lambda
#3128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncik-roberts
approved these changes
Oct 9, 2024
ccasin
added a commit
that referenced
this pull request
Oct 9, 2024
lukemaurer
pushed a commit
to lukemaurer/flambda-backend
that referenced
this pull request
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-stop-after lambdais broken in ocamlopt right now - we don't actually stop after lambda. This fixes it.This is visible in several ways, but the one that is annoying me at the moment is that we eventually end up reaching this line and terminate with exit code 0 even in some cases where we should have a non-zero exit code. I've added a test that demonstrates this in the first commit, and then fixed it in the second.