Extend Pblock value kind to handle variants #703
Conversation
mshinwell
requested review from
lpw25,
antalsz,
gretay-js,
xclerc,
lukemaurer,
lthls and
chambart
as code owners
|
One thing that may need discussion is the "fuel" setting, by the way. |
mshinwell
force-pushed
the
lambda-variant-kind
branch
3 times, most recently
from
80b7086 to
5dda254
Compare
There was a problem hiding this comment.
The changes to typeopt look correct.
However, I'm worried about the size of data you might be creating here. There is no sharing between different occurences of the same type, and it would not take that many constructors with that many fields before the size becomes very large. In particular, you are now going to get blocks for recursive types, so you are much more likely to see a large type nested immediately inside another large type. I would suggest that the fuel reduction on each iteration should take account of the number of constructors, and probably the number of fields that a type has.
|
Yeah, I will add some aggressive fuel reduction. I think we should probably forbid |
In theory we would have more precise information with a const-only |
mshinwell
force-pushed
the
lambda-variant-kind
branch
from
5dda254 to
812e40e
Compare
|
I've added a new fuel algorithm, comments welcome (particularly on the setting of the various fuel usage parameters). |
|
(Test failures will be due to |
mshinwell
force-pushed
the
lambda-variant-kind
branch
from
5af09b4 to
211276c
Compare
ce76e02 flambda-backend: Bugfix for type_application (#746) 44f3afb flambda-backend: PR580 for main branch (#743) b851eaa flambda-backend: Backport first part of ocaml/ocaml PR10498 (#737) fafb4bd flambda-backend: Fix return mode for eta-expanded function in type_argument (#735) c31f6c3 flambda-backend: Fix treatment of functions called [@nontail] (#725) 847781e flambda-backend: Fix build_upstream post-PR703 (#712) bfcbbf8 flambda-backend: Extend Pblock value kind to handle variants (#703) b2cab95 flambda-backend: Merge ocaml-jst a6d6e0e flambda-backend: Merge ocaml-jst 88a4f63 flambda-backend: Use Pmakearray for immutable arrays (#699) eeaa44b flambda-backend: Install an ocamldoc binary (#695) 48d322b flambda-backend: Ensure that GC is not invoked from bounds check failures (#681) 4370fa1 flambda-backend: Review changes of term directory (#602) 65a4566 flambda-backend: Add code coverage using bisect_ppx (#352) 63ab65f flambda-backend: Bugfix for primitive inclusion (#662) 7e3e0c8 flambda-backend: Fix inclusion checks for primitives (#661) 96c68f9 flambda-backend: Speed up linking by changing cmxa format (#607) 1829150 flambda-backend: Bugfix for Translmod.all_idents (#659) git-subtree-dir: ocaml git-subtree-split: ce76e02
This replaces the existing
Pblockvalue kind used inLambdawith aPvariantkind. This allows Flambda 2 to have more precise types for function parameters.I'll tidy up the printing functions after any review comments have been received on the remainder.