Cookbook recipes to parse command-line arguments #3038
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can't understand why the CI failed. I'll investigate If someone has seeing this before, I would appreciate any help. |
boechat107
commented
Mar 28, 2025
Comment on lines
21
to
27
| let arg_module_parser () = | ||
| let usage_msg = | ||
| "mycmd [--verbose] <file1> [<file2>] ... -o <output>" | ||
| and verbose = ref false | ||
| and input_files = ref [] | ||
| and output_file = ref "" in | ||
| (* This function is called once for each anonymous argument. *) |
There was a problem hiding this comment.
ood-gen is parsing this whole block as a Str.Text, except for the final delimiter *). There seems to be something wrong with the string splitting (Str.full_split, line 72).
There was a problem hiding this comment.
Ok, got it. The regex expect the delimiter (* always at the beginning of the line. This code has indented comments.
There was a problem hiding this comment.
I couldn't find any comments about this comments restriction. Would it make sense to add a comment? Or would it be better to change the regex pattern?
"ood-gen" uses a regex pattern that expects comments starting only at the beginning of lines.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recipes in this PR contains three alternative ways to parse command-line arguments:
Sys.argvdirectly.Argmodule from the standard library.Cmdlinerinstalled throughopam.