Skip to content
This repository was archived by the owner on Feb 15, 2022. It is now read-only.

Move tutorial individual page to /resources/tutorials/ #503

Merged
2 commits merged into from
Aug 14, 2021

Conversation

renatoalencar
Copy link
Contributor

@renatoalencar renatoalencar commented Aug 7, 2021

Moving [tutorial].res to the tutorials directory under resources as described on #487

Modified relative paths:

https://v3-ocaml-org-git-BRANCH_NAME-ocaml.vercel.app/PATH/TO/PAGE

https://v3-ocaml-org-git-fork-FORK_NAME-BRANCH_NAME-ocaml.vercel.app/PATH/TO/PAGE

Contributor Pre-flight Checklist

  • Accessibility check - checked pa11y report for modified pages, observing new errors
  • Responsive check - visually inspected vercel preview, using responsive tool to toggle between desktop and mobile view
  • HTML review - use browser DOM/Page inspector to inspect generated HTML within <div id="__next>" element

@vercel
Copy link

vercel bot commented Aug 7, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/ocaml/v3-ocaml-org/C3UvEb1ggBFPfT29HHtfAQNJDEcp
✅ Preview: https://v3-ocaml-org-git-fork-renatoalencar-move-tutorials-ocaml.vercel.app

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. There is another tangentially related issue that involves this area of code, but it can be addressed in a different PR.

@renatoalencar
Copy link
Contributor Author

This looks good. There is another tangentially related issue that involves this area of code, but it can be addressed in a different PR.

Could you reference it here? I could try to do that.

@ghost
Copy link

ghost commented Aug 14, 2021

Thanks!

@ghost ghost merged commit 2193e36 into ocaml:master Aug 14, 2021
@renatoalencar renatoalencar deleted the move-tutorials branch August 18, 2021 17:56
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant