Skip to content
This repository was archived by the owner on Feb 15, 2022. It is now read-only.

Added World Map to Academic Excellence Page #513

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

shreyaswikriti
Copy link
Contributor

Added World Map to Academic Excellence Page, presenting all universities with map marker.
Used ReScript bindings for React-Leaflet.
Used Dynamic Import functionality of NextJs with No SSR for leaflet rendering map in the browser.
Fetched location data (latitude and longitude) from ood/academic_institution to mark all universities on the map.
Screenshot from 2021-08-11 17-45-38

Modified relative paths:

https://v3-ocaml-org-git-BRANCH_NAME-ocaml.vercel.app/PATH/TO/PAGE

https://v3-ocaml-org-git-fork-FORK_NAME-BRANCH_NAME-ocaml.vercel.app/PATH/TO/PAGE

Contributor Pre-flight Checklist

  • Accessibility check - checked pa11y report for modified pages, observing new errors
  • Responsive check - visually inspected vercel preview, using responsive tool to toggle between desktop and mobile view
  • HTML review - use browser DOM/Page inspector to inspect generated HTML within <div id="__next>" element

@vercel
Copy link

vercel bot commented Aug 11, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/ocaml/v3-ocaml-org/7htxCyHX7oWREA8R7iAAvajX3ey4
✅ Preview: https://v3-ocaml-org-git-fork-shreyaswikriti-acad-ocaml.vercel.app

@ghost
Copy link

ghost commented Aug 11, 2021

Amazing!

Copy link
Contributor

@patricoferris patricoferris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is excellent @shreyaswikriti and a really non-trivial task to deal with the dynamic imports and Rescript. Just a few comments :))

@vercel
Copy link

vercel bot commented Sep 6, 2021

Deployment failed with the following error:

The most recent charge for your active payment method has failed. Please update it here: https://vercel.com/teams/ocaml/settings/billing.

@patricoferris
Copy link
Contributor

@shreyaswikriti I just pushed some changes to bring this PR up to date and update ood so the longitudes fixes are now in. Once we work out the vercel problem, this should be good to go. Thanks for the PR doing all of the leg work :))

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants