-
Notifications
You must be signed in to change notification settings - Fork 10
Added World Map to Academic Excellence Page #513
base: master
Are you sure you want to change the base?
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/ocaml/v3-ocaml-org/7htxCyHX7oWREA8R7iAAvajX3ey4 |
Amazing! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is excellent @shreyaswikriti and a really non-trivial task to deal with the dynamic imports and Rescript. Just a few comments :))
Deployment failed with the following error:
|
@shreyaswikriti I just pushed some changes to bring this PR up to date and update ood so the longitudes fixes are now in. Once we work out the vercel problem, this should be good to go. Thanks for the PR doing all of the leg work :)) |
Added World Map to Academic Excellence Page, presenting all universities with map marker.

Used ReScript bindings for React-Leaflet.
Used Dynamic Import functionality of NextJs with No SSR for leaflet rendering map in the browser.
Fetched location data (latitude and longitude) from ood/academic_institution to mark all universities on the map.
Modified relative paths:
https://v3-ocaml-org-git-BRANCH_NAME-ocaml.vercel.app/PATH/TO/PAGE
https://v3-ocaml-org-git-fork-FORK_NAME-BRANCH_NAME-ocaml.vercel.app/PATH/TO/PAGE
Contributor Pre-flight Checklist
<div id="__next>"
element