Skip to content
This repository was archived by the owner on Feb 15, 2022. It is now read-only.

Trim JS rewrapping modules to the bare minimum needed #62

Closed
wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Jan 15, 2021

#19 Addressed properly wrapping rescript page modules with JS. This issue involves reducing the code in each of these boilerplate files down. This example (https://github.com/reason-association/rescript-lang.org/blob/master/pages/blog/%5Bslug%5D.js) is probably the least amount of code to accomplish the same behavior. Try using that and replacing existing wrappers with that code instead.

@vercel
Copy link

vercel bot commented Jan 15, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/solvuu/ocamlorg2/6wjxbg9v8
✅ Preview: https://ocamlorg2-git-kanishka-work-patch-5.solvuu.vercel.app

@ghost ghost added the enhancement label Jan 15, 2021
@ghost
Copy link
Author

ghost commented Mar 23, 2021

Convert this back into an issue. Add it as a prerequisite for #140

@agarwal
Copy link
Member

agarwal commented Mar 23, 2021

Convert this back into an issue. Add it as a prerequisite for #140

Or maybe just add comments to #140, stating how the new code should look. That way the code generator there can simply implement the suggestion. I'm not sure it'll be worth making this change manually to all of our files if #140 will delete them and auto-generate.

@ghost ghost closed this Apr 6, 2021
@ghost ghost deleted the kanishka-work-patch-5 branch April 22, 2021 14:54
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant