Fix metal backend memory leaks #8276
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello Selim, Could you confirm that this also works properly when NOT using metal-cpp? Thank you! |
|
Hi @ocornut, #7419 fixes some of the leaks, this fixes the rest that happen when using metal-cpp. I used a different approach in previous commit, this one is much simpler. I don't really know why autoreleasepools instantiated in c++ code cannot catch these 2 objects (depthStencilDescriptor and framebufferDescriptor) but now they are released properly. Tested with both objc and metal-cpp code. |
ocornut
pushed a commit
that referenced
this pull request
Jan 8, 2025
|
Thank you Selim! Squashed and merged as e6a7c76! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes all runtime memory leaks when using the backend with metal-cpp. There are still some leaks left that needs to be fixed that occur at startup.