Skip to content

ci: stop testing against NodeJS v14, v16 #637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jun 12, 2023
Merged

ci: stop testing against NodeJS v14, v16 #637

merged 9 commits into from
Jun 12, 2023

Conversation

wolfy1339
Copy link
Member

@wolfy1339 wolfy1339 commented May 13, 2023 •
edited
Loading

BREAKING CHANGE: Drop support for NodeJS v14, v16

@wolfy1339 wolfy1339 added Type: Breaking change Used to note any change that requires a major version bump Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR labels May 13, 2023
@wolfy1339 wolfy1339 force-pushed the remove-eol-node-versions branch from 443f700 to b1f0858 Compare May 13, 2023 16:33
@wolfy1339 wolfy1339 changed the title ci: stop testing against NodeJS v14 ci: stop testing against NodeJS v14, v16 May 14, 2023
@wolfy1339 wolfy1339 force-pushed the remove-eol-node-versions branch from b1f0858 to 13a32c8 Compare May 14, 2023 02:06
kfcampbell
kfcampbell previously approved these changes May 19, 2023
View reviewed changes
@nickfloyd
Copy link
Contributor

https://github.com/orgs/octokit/discussions/44

@wolfy1339 wolfy1339 changed the base branch from main to beta June 9, 2023 19:08
@wolfy1339 wolfy1339 dismissed kfcampbell’s stale review June 9, 2023 19:08

The base branch was changed.

@wolfy1339 wolfy1339 requested a review from kfcampbell June 9, 2023 19:10
@wolfy1339
Copy link
Member Author

Branch protection rules nees to be fixed for the beta branch. It needs to point to the test job, and not the old ones which have node versions in their name

@kfcampbell kfcampbell mentioned this pull request Jun 9, 2023
Merged
@kfcampbell
Copy link
Member

@wolfy1339 I think the next steps here and in plugin-paginate-graphql.js should look something like:

  • Merge Node deprecation PRs into the beta branch
  • Create/merge PRs into the beta branch to bump any related Octokit dependencies' major versions
  • Create/merge a breaking change PR from the beta branch

Are you comfortable proceeding with these steps?

@wolfy1339
Copy link
Member Author

Those steps look good

@wolfy1339 wolfy1339 merged commit b451e6e into beta Jun 12, 2023
@wolfy1339 wolfy1339 deleted the remove-eol-node-versions branch June 12, 2023 21:58
@github-actions
Copy link
Contributor

🎉 This PR is included in version 8.0.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

millermusk56
millermusk56 reviewed Apr 1, 2025
View reviewed changes
Copy link

@millermusk56 millermusk56 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

iCloud Passkeys

@millermusk56
Copy link

iPhone 16 passkeys

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@millermusk56 millermusk56 millermusk56 left review comments

@kfcampbell kfcampbell kfcampbell approved these changes

Assignees
No one assigned
Labels
released on @beta Type: Breaking change Used to note any change that requires a major version bump Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR
Projects
🧰 Octokit Active
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wolfy1339 @nickfloyd @kfcampbell @millermusk56