-
Notifications
You must be signed in to change notification settings - Fork 61
chore: improve getResponseData #715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with |
@gr2m |
The whole Octokit ecosystem (apart from some exceptions) has browser support. |
I introduced the package fast-content-type-parse. It is a package I wrote myself, as I mentioned before. It is imho more reliable than using regexes. We use it in fastify. Using safeParse to not throw errors if the content type is invalid. The chance is imho slim. Also i think i made it more resilient, because it has no chance to throw anymore ;). |
🎉 This PR is included in version 9.1.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
first #711 should be merged, than I want to see if there is some aspects regarding resilience.