Skip to content

Feature/#233 api sharing #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Oct 17, 2018
Merged

Feature/#233 api sharing #12

merged 7 commits into from
Oct 17, 2018

Conversation

sanderegg
Copy link

What do these changes do?

  • removal of status from envelopes in responses from director
  • updated director api
  • added tests for handlers
  • updated frontend to check for error instead of checking status code

Related issue number

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you design a new module, add your user to .github/CODEOWNERS

@odeimaiz odeimaiz merged commit e258613 into odeimaiz:feature/sim-widget Oct 17, 2018
@sanderegg sanderegg deleted the feature/#233_api_sharing branch November 2, 2018 08:48
odeimaiz pushed a commit that referenced this pull request Nov 30, 2018
@pcrespov
Merge pull request #12 from sanderegg/pcrespov-is207/reverse-proxy-di…
5eda454 
…rector

director updated to pass the basepath and return internal infos

- director passes the base path to started services in SIMCORE_NODE_BASEPATH
- director returns service_host, service_port and service_basepath as defined in the specs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sanderegg @odeimaiz