Skip to content

Odeimaiz feature/fix save as template #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

sanderegg
Copy link

missing tests for accessRights modifications

@codecov-io
Copy link

Codecov Report

Merging #69 into feature/fix-save-as-template will decrease coverage by 18.39%.
The diff coverage is n/a.

Impacted file tree graph

@@                        Coverage Diff                        @@
##           feature/fix-save-as-template      #69       +/-   ##
=================================================================
- Coverage                         71.66%   53.27%   -18.40%     
=================================================================
  Files                               245       90      -155     
  Lines                              9804     2506     -7298     
  Branches                           1076      263      -813     
=================================================================
- Hits                               7026     1335     -5691     
+ Misses                             2473     1118     -1355     
+ Partials                            305       53      -252     
Flag Coverage Δ
#integrationtests ?
#unittests 53.27% <ø> (-10.33%) ⬇️
Impacted Files Coverage Δ
...re-sdk/src/simcore_sdk/node_ports/serialization.py 24.61% <0.00%> (-56.93%) ⬇️
...core-sdk/src/simcore_sdk/node_ports/filemanager.py 22.22% <0.00%> (-54.77%) ⬇️
...imcore-sdk/src/simcore_sdk/node_ports/dbmanager.py 38.33% <0.00%> (-48.34%) ⬇️
...imcore-sdk/src/simcore_sdk/node_ports/nodeports.py 27.77% <0.00%> (-47.78%) ⬇️
...es/simcore-sdk/src/simcore_sdk/node_ports/_item.py 50.92% <0.00%> (-42.60%) ⬇️
...sdk/src/simcore_sdk/node_ports/data_items_utils.py 62.50% <0.00%> (-37.50%) ⬇️
...mcore-sdk/src/simcore_sdk/node_ports/exceptions.py 59.09% <0.00%> (-13.64%) ⬇️
...core-sdk/src/simcore_sdk/models/pipeline_models.py 51.51% <0.00%> (-12.13%) ⬇️
...k/src/simcore_sdk/node_ports/_schema_items_list.py 91.30% <0.00%> (-8.70%) ⬇️
...sdk/src/simcore_sdk/node_ports/_data_items_list.py 55.26% <0.00%> (-7.90%) ⬇️
... and 156 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee1678f...23b2b79. Read the comment docs.

@odeimaiz odeimaiz merged commit ab4f5af into odeimaiz:feature/fix-save-as-template May 8, 2020
@sanderegg sanderegg deleted the odeimaiz-feature/fix-save-as-template branch May 12, 2020 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants