[IMP] Odoo 15.0-17.0: Make psycopg2.connect dbname configurable. #482
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
POSTGRES_DB per Environment Variables section of https://hub.docker.com/_/postgres/ |
This allows the system administrator to set the standard PostgreSQL environment variable POSTGRES_DB to change the name of the database created by default. Fixes odoo#358.
|
So I've tested a bit and now think this pull request is dead on arrival. Here's why: --database doesn't have to be just one value, so it's not guaranteed to be reasonable to be passed to This is a side effect of the arguments parsed in entrypoint.sh being used for both wait-for-psql.py and the odoo binary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the system administrator to set the standard PostgreSQL environment variable POSTGRES_DB to change the name of the database created by default.
Fixes #358.