-
Notifications
You must be signed in to change notification settings - Fork 9.1k
[IMP] studio: updating datetime field info #12350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
372184b
to
243bb48
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @mcsi-odoo thank you for your work; this is definitely worth documenting!
I think the screenshot you added is a great idea and really helps clarify the different options. One general note about screenshots (and I know you didn’t do this): would you consider removing the center alignment for all of them 🙈? (You don't have to 😉 )
- :guilabel:`Widget`: To change the default appearance or functionality of a field, select one of | ||
the available widgets. | ||
- :guilabel:`Placeholder`: To provide an example of how a field should be completed, write it under | ||
:guilabel:`Placeholder`. It appears in light gray as a placeholder until a value is entered. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know you didn't change this, but I don't think repeating the field's label is necessary?
0d5ebf5
to
f0e2651
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the changes @mcsi-odoo! I only have a few minor comments 🙂
This did, however, open another can of worms for me 🙈 but I think it's best to address it in a separate task and PR, especially since it's not urgent at all.
(Also see my comment on line 201) I actually think we could restructure/review the page a bit to:
- Explain how to add a field and mention the general properties at the top of the page (they are a bit lost at the bottom right now).
- Move the Date & Time properties to the relevant section (before the widget-specific sections).
- Look into documenting other field/widget-specific properties for other field types as well.
What do you think?
Task-4366107
f0e2651
to
850bb1f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again @mcsi-odoo ! Nice work on this!!
@robodoo r+
Task-4366107 closes #12350 Signed-off-by: Audrey Vandromme (auva) <[email protected]>
Task-4366107