[IMP] Purchase: Update RFQ with dependency warnings and new images #12682

slinkous · 2025-03-28T17:33:43Z

No description provided.

robodoo · 2025-03-28T17:33:49Z

Felicious

Looks great @slinkous !

Approved with minor nitpicks (:

content/applications/inventory_and_mrp/purchase/manage_deals/rfq.rst

StraubCreative

Hi @slinkous
Approving with some comments to consider.
When you're ready can pass to @samueljlieber for merge, thank you!

StraubCreative · 2025-04-02T18:54:39Z

content/applications/inventory_and_mrp/purchase/manage_deals/rfq.rst

 To auto-populate product information and prices on an |RFQ|, configure products by going to
-:menuselection:`Purchase app --> Products --> Products`. Select an existing product, or create a
-new one by selecting :guilabel:`New`. Doing so opens the product form, where various sales and
-purchasing data can be configured.
+:menuselection:`Purchase app --> Products --> Products`. Select an existing product, or create a new
+one by selecting :guilabel:`New`. Doing so opens the product form, where sales and purchasing data
+can be configured.


If we're going to touch this section up then I think we can go further.
We can:

be more concise by removing unnecessary words and instructions

remove passive language in favor of the active voice

add time order language to imply an ordered sequence of steps

be more explicit in cause/effect actions (i.e. if/then/else statements, do this and then this happens, etc.)

be more specific with certain words and instructions (we don't select the New button because it's not presented as a choice as though it were in a menu with other list items, we click it).

Suggested change

To auto-populate product information and prices on an |RFQ|, configure products by going to

:menuselection:`Purchase app --> Products --> Products`. Select an existing product, or create a

new one by selecting :guilabel:`New`. Doing so opens the product form, where various sales and

purchasing data can be configured.

:menuselection:`Purchase app --> Products --> Products`. Select an existing product, or create a new

one by selecting :guilabel:`New`. Doing so opens the product form, where sales and purchasing data

can be configured.

To auto-populate product information and prices on an |RFQ|, first configure the product(s) by going

to :menuselection:`Purchase app --> Products --> Products`. In the list, find the existing product,

or create a new one by clicking the :guilabel:`New` button. Then, on the product's form, fill in the

necessary sales and purchasing data, so it loads across document line items automatically.

StraubCreative · 2025-04-02T19:04:38Z

content/applications/inventory_and_mrp/purchase/manage_deals/rfq.rst

-information auto-populate on an |RFQ| each time the product is listed.
+In the :guilabel:`Purchase` tab of the product form, click :guilabel:`Add a line` to input the
+vendor and their price, to have this information auto-populate on an |RFQ| each time the product is
+listed.


Suggest to pluralize "vendor" to "vendors" and then explain how the order in the list matters (the vendor at the top of the list is preferred across other operations like reordering rules)

StraubCreative · 2025-04-02T19:06:01Z

content/applications/inventory_and_mrp/purchase/manage_deals/rfq.rst

 To enable or disable columns, click the :icon:`oi-settings-adjust` :guilabel:`(additional options)`
 icon on the right side of the header row to reveal a drop-down menu of additional columns that can
 be added (or removed) from the :guilabel:`Purchase` tab.


Essentials content, can remove
It's better to more deeply explain the what default columns mean and how to fill them in correctly.

Suggested change

To enable or disable columns, click the :icon:`oi-settings-adjust` :guilabel:`(additional options)`

icon on the right side of the header row to reveal a drop-down menu of additional columns that can

be added (or removed) from the :guilabel:`Purchase` tab.

StraubCreative · 2025-04-02T19:06:59Z

content/applications/inventory_and_mrp/purchase/manage_deals/rfq.rst

-   going to :menuselection:`Purchase app --> Configuration --> Vendor Pricelists`. Click
-   :guilabel:`New` in the top-left corner. In the :guilabel:`Vendor` section of the pricelist form
-   that appears, add the product information as it pertains to the vendor.
+   Alternatively, prices and delivery lead times for existing products can be added by going to


The explicit "bulk" part here is a useful tip, I don't see the need to remove it?

StraubCreative · 2025-04-02T19:07:41Z

content/applications/inventory_and_mrp/purchase/manage_deals/rfq.rst

+In addition to view options, the :guilabel:`Requests for Quotation` dashboard provides
 :guilabel:`Filters` and :guilabel:`Group By` options, accessible via the search bar drop-down menu.


essentials content can remove

StraubCreative · 2025-04-02T19:10:50Z

content/applications/inventory_and_mrp/purchase/manage_deals/rfq.rst

-The :guilabel:`Blanket Order` field refers to long-term purchase agreements on recurring orders with
-set pricing. To view and configure blanket orders, head to :menuselection:`Purchase app --> Orders
--> Purchase agreements`.
+With the :doc:`Purchase Agreements feature <blanket_orders>` activated, the :guilabel:`Blanket


I like that we're talking about blanket orders and dropshipping, but at this location in the content, it seems a bit premature since we're simply just trying to create an RFQ? We don't need any of these features enabled in order to create an RFQ...

slinkous · 2025-04-03T17:16:31Z

@samueljlieber branch is ready to merge.

Per discussion with Zac, we'll make his suggested changes in a follow-up PR to keep this PR focused on its original goal.

samueljlieber

Hi @slinkous, thank you for your work on this PR! Your changes look good to me. Approving with a quick fix! Feel free to merge after, thank you!
..
@robodoo delegate=slinkous

content/applications/inventory_and_mrp/purchase/manage_deals/rfq.rst

Apply suggestions from code review Co-authored-by: Felicia Kuan <[email protected]> fix edits ddfsdf . Update content/applications/inventory_and_mrp/purchase/manage_deals/rfq.rst Co-authored-by: Sam Lieber (sali) <[email protected]>

slinkous · 2025-04-04T22:09:45Z

@robodoo r+

slinkous · 2025-04-04T22:10:38Z

@robodoo r+

robodoo · 2025-04-04T22:10:41Z

This PR is already reviewed, reviewing it again is useless.

slinkous requested a review from Felicious March 28, 2025 17:33

C3POdoo requested a review from a team March 28, 2025 17:35

slinkous self-assigned this Mar 28, 2025

slinkous closed this Mar 28, 2025

Felicious approved these changes Mar 28, 2025

View reviewed changes

slinkous reopened this Mar 28, 2025

Felicious changed the base branch from 18.0 to 17.0 March 28, 2025 18:56

Felicious changed the base branch from 17.0 to 18.0 March 28, 2025 18:57

slinkous force-pushed the 18.0-purchase-rfq-stul branch 3 times, most recently from 92a8d6d to 12cb8eb Compare March 31, 2025 22:34

slinkous added the 2 label Apr 2, 2025

slinkous force-pushed the 18.0-purchase-rfq-stul branch from 12cb8eb to e8a1d09 Compare April 2, 2025 00:35

slinkous requested a review from a team April 2, 2025 18:27

StraubCreative approved these changes Apr 2, 2025

View reviewed changes

samueljlieber approved these changes Apr 4, 2025

View reviewed changes

content/applications/inventory_and_mrp/purchase/manage_deals/rfq.rst Outdated Show resolved Hide resolved

slinkous force-pushed the 18.0-purchase-rfq-stul branch from de0bd81 to 14d0184 Compare April 4, 2025 21:35

robodoo closed this in 14b7183 Apr 5, 2025

robodoo temporarily deployed to merge April 5, 2025 01:27 Inactive

This was referenced Apr 5, 2025

[FW][IMP] Purchase: Update RFQ with dependency warnings and new images #12806

Open

[FW][IMP] Purchase: Update RFQ with dependency warnings and new images #12807

Open

[FW][IMP] Purchase: Update RFQ with dependency warnings and new images #12808

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[IMP] Purchase: Update RFQ with dependency warnings and new images #12682

[IMP] Purchase: Update RFQ with dependency warnings and new images #12682

slinkous commented Mar 28, 2025

robodoo commented Mar 28, 2025

Felicious left a comment

StraubCreative left a comment

StraubCreative Apr 2, 2025

StraubCreative Apr 2, 2025

StraubCreative Apr 2, 2025

StraubCreative Apr 2, 2025

StraubCreative Apr 2, 2025

StraubCreative Apr 2, 2025

slinkous commented Apr 3, 2025

samueljlieber left a comment

slinkous commented Apr 4, 2025

slinkous commented Apr 4, 2025

robodoo commented Apr 4, 2025

	To enable or disable columns, click the :icon:`oi-settings-adjust` :guilabel:`(additional options)`
	icon on the right side of the header row to reveal a drop-down menu of additional columns that can
	be added (or removed) from the :guilabel:`Purchase` tab.

		In addition to view options, the :guilabel:`Requests for Quotation` dashboard provides
		:guilabel:`Filters` and :guilabel:`Group By` options, accessible via the search bar drop-down menu.

[IMP] Purchase: Update RFQ with dependency warnings and new images #12682

[IMP] Purchase: Update RFQ with dependency warnings and new images #12682

Conversation

slinkous commented Mar 28, 2025

robodoo commented Mar 28, 2025

Felicious left a comment

Choose a reason for hiding this comment

StraubCreative left a comment

Choose a reason for hiding this comment

StraubCreative Apr 2, 2025

Choose a reason for hiding this comment

StraubCreative Apr 2, 2025

Choose a reason for hiding this comment

StraubCreative Apr 2, 2025

Choose a reason for hiding this comment

StraubCreative Apr 2, 2025

Choose a reason for hiding this comment

StraubCreative Apr 2, 2025

Choose a reason for hiding this comment

StraubCreative Apr 2, 2025

Choose a reason for hiding this comment

slinkous commented Apr 3, 2025

samueljlieber left a comment

Choose a reason for hiding this comment

slinkous commented Apr 4, 2025

slinkous commented Apr 4, 2025

robodoo commented Apr 4, 2025