[IMP] website: general themes restructuration #12745
Conversation
|
|
auva-odoo
changed the title
There was a problem hiding this comment.
@guga-odoo thank you for you work on this PR! I think this new structure makes this doc page more clear and overall useful to users. In addition to my review comments:
- Could you please edit your commit message to have the taskid on a new line? 🙏
- I would also document the status colors (like I mentioned in my comment on line 18). Yiu can refer to the last part of these instructions to see what I mean exactly: last part of these instructions: https://scribehow.com/shared/Edit_the_colors__tnLBFBPTQDeCDl6cbfEW-Q)
As usual, let me know if anything’s unclear or if you want to discuss my comments in person!
content/applications/websites/website/web_design/themes/color-presets.png
Outdated
Show resolved
Hide resolved
guga-odoo
force-pushed
the
18.0-website-theme-general-guga
branch
3 times, most recently
from
a5218bd to
098d70d
Compare
There was a problem hiding this comment.
Thank you for the updates, @guga-odoo ! Great work adding explanations for the color presets, status colors, and Google Fonts (served from Google servers)! 👏
I’ve added a few more comments and suggestions. Let me know if anything’s unclear or if you’d like to discuss any of them!
guga-odoo
force-pushed
the
18.0-website-theme-general-guga
branch
from
098d70d to
04937d5
Compare
task-4644985
auva-odoo
force-pushed
the
18.0-website-theme-general-guga
branch
from
04937d5 to
f600e03
Compare
There was a problem hiding this comment.
Thank you @guga-odoo for the changes and for working on this! Nice work!
I pushed some minor changes (removed unnecessary spaces/capital letters and added a ref).
@robodoo r+
task-4644985 closes #12745 Signed-off-by: Audrey Vandromme (auva) <[email protected]>
|
@guga-odoo @auva-odoo staging failed: ci/runbot on 862f689b9b6778cbb24f3e648695adda87812d76 (view more at https://runbot.odoo.com/runbot/build/78110556) |
|
@robodoo retry |
task-4644985 closes #12745 Signed-off-by: Audrey Vandromme (auva) <[email protected]>
task-4644985