[IMP] plm: trim essentials, update style #12792
Closed
+30
−87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Felicious
approved these changes
Apr 4, 2025
content/applications/inventory_and_mrp/plm/management/approvals.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/plm/management/approvals.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/plm/management/approvals.rst
Outdated
Show resolved
Hide resolved
slinkous
force-pushed
the
18.0-plm-approvals-stul
branch
from
9be39dc to
bad7619
Compare
|
This is ready to merge @samueljlieber |
samueljlieber
requested changes
Apr 9, 2025
There was a problem hiding this comment.
Hi @slinkous, thank you for your work! This is a great PR to trim the essentials content, linking to existing Activities documentation!
I am requesting changes as there are a few items to address.
Please run make review on the image folder (content/applications/inventory_and_mrp/plm/management/approvals) to locate and remove image files that are no longer used in this doc.
Please tag me for another look once these have been addressed, thank you!
content/applications/inventory_and_mrp/plm/management/approvals.rst
Outdated
Show resolved
Hide resolved
slinkous
force-pushed
the
18.0-plm-approvals-stul
branch
from
a402a2f to
6fb4876
Compare
Apply suggestions from code review Co-authored-by: Felicia Kuan <[email protected]> Abbrv Apply suggestions from code review Co-authored-by: Sam Lieber (sali) <[email protected]> Remove images
slinkous
force-pushed
the
18.0-plm-approvals-stul
branch
from
6fb4876 to
0a88dc7
Compare
|
Images reviewed, label text updated to match tooltip @samueljlieber |
This was referenced Apr 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.