Skip to content

[ADD] estate module #788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 14 commits into
base: 18.0
Choose a base branch
from
Open

Conversation

thha-odoo
Copy link

No description provided.

@robodoo
Copy link

robodoo commented May 19, 2025

Pull request status dashboard

@thha-odoo thha-odoo force-pushed the 18.0-tutorial-thha branch from 23797fa to 452d3a5 Compare May 20, 2025 09:57
Copy link

@ushyme ushyme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work overall 👍🏾. Here are a few things that can be improved:

  • IDE-specific configurations are user-dependent and should not be included in the codebase. So your .idea folder should not be here.
  • we generally use different quote signs to distinguishes between technical strings (single quotes) and user-facing strings (double quotes).
  • be mindful of your commit messages; more specifically, the commit title needs to follow a specific structure
  • Remember to leave an empty line at the end of files. While it seems trivial, it ensures compatibility with many tools and version control systems.

thha-odoo added 5 commits May 23, 2025 10:35
Adding smart buttons, default filter, offer colors and property colors
IDE files in .gitignore
inverse attribute not fixed
Mapped method
Fixing EstateProperty.action_sold method
Improving EstateProperty._get_best_offer
Renaming for following convention
Fixing EstatePropertyOffer._compute_date_deadline , _compute_date_deadline_inverse and action_accepted methods
Overriding offer create method
Inheriting user view to add the available properties
Adding estate_account module
Adding invoice creation on property sold button pushed
Adding kanban view
Fixing code for passing runbot tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants