-
Notifications
You must be signed in to change notification settings - Fork 2.1k
[ADD] estate module #788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
thha-odoo
wants to merge
14
commits into
odoo:18.0
Choose a base branch
from
thha-odoo:18.0-tutorial-thha
base: 18.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[ADD] estate module #788
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23797fa
to
452d3a5
Compare
Buttons sold and cancelled added
Adding python and SQL constraints
ushyme
suggested changes
May 23, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work overall 👍🏾. Here are a few things that can be improved:
- IDE-specific configurations are user-dependent and should not be included in the codebase. So your
.idea
folder should not be here. - we generally use different quote signs to distinguishes between technical strings (single quotes) and user-facing strings (double quotes).
- be mindful of your commit messages; more specifically, the commit title needs to follow a specific structure
- Remember to leave an empty line at the end of files. While it seems trivial, it ensures compatibility with many tools and version control systems.
Adding smart buttons, default filter, offer colors and property colors
IDE files in .gitignore inverse attribute not fixed Mapped method Fixing EstateProperty.action_sold method Improving EstateProperty._get_best_offer Renaming for following convention Fixing EstatePropertyOffer._compute_date_deadline , _compute_date_deadline_inverse and action_accepted methods
Overriding offer create method Inheriting user view to add the available properties
Adding estate_account module Adding invoice creation on property sold button pushed
Adding kanban view Fixing code for passing runbot tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.