Skip to content

[ADD] awesome_owl: it adds basics for a todo list #801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: 18.0
Choose a base branch
from

Conversation

MaximeNoirhomme229
Copy link

@MaximeNoirhomme229 MaximeNoirhomme229 commented May 28, 2025

  • Adds nice card implementation
  • Adds intuitive counter with an associated callback on pressed (which allows, for instance, to add up severals counter values)
  • A todo list:
    • It can add a new todo
    • It can delete a todo
    • It can modify the check state of a todo

@robodoo
Copy link

robodoo commented May 28, 2025

Pull request status dashboard

Copy link

@barracudapps barracudapps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nitpicking comments

Comment on lines 1 to 2
import { Component } from "@odoo/owl";
export class TodoItem extends Component {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
import { Component } from "@odoo/owl";
export class TodoItem extends Component {
import { Component } from "@odoo/owl";
export class TodoItem extends Component {

Check all your files 😉
Same as for the other tutorial

</t>

<t t-name="awesome_owl.playground">
<div class="card" style="display: flex; gap: 20px; padding: 10px;">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid hardcoding styles. Prefer BootStrap and Odoo classes

@MaximeNoirhomme229
Copy link
Author

Thank you for the review!

<?xml version="1.0" encoding="UTF-8" ?>
<templates xml:space="preserve">
<t t-name="awesome_owl.Card">
<div class="card d-inline-block m-2" style="width: 18rem;">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still some hardcoded styles here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants