-
Notifications
You must be signed in to change notification settings - Fork 2.1k
[ADD] awesome_owl: it adds basics for a todo list #801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 18.0
Are you sure you want to change the base?
[ADD] awesome_owl: it adds basics for a todo list #801
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some nitpicking comments
import { Component } from "@odoo/owl"; | ||
export class TodoItem extends Component { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
import { Component } from "@odoo/owl"; | |
export class TodoItem extends Component { | |
import { Component } from "@odoo/owl"; | |
export class TodoItem extends Component { |
Check all your files 😉
Same as for the other tutorial
</t> | ||
|
||
<t t-name="awesome_owl.playground"> | ||
<div class="card" style="display: flex; gap: 20px; padding: 10px;"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid hardcoding styles. Prefer BootStrap and Odoo classes
Thank you for the review! |
awesome_owl/static/src/card/card.xml
Outdated
<?xml version="1.0" encoding="UTF-8" ?> | ||
<templates xml:space="preserve"> | ||
<t t-name="awesome_owl.Card"> | ||
<div class="card d-inline-block m-2" style="width: 18rem;"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still some hardcoded styles here
Uh oh!
There was an error while loading. Please reload this page.