18.0 tutorial importable modules aras #811

abdrahmanrashed · 2025-06-06T15:26:49Z

No description provided.

-added menus to access estate views from main menu.

-Added list view to estate property type. -Added menu to access estate property type. -Added access rights to estate property type. -Added some related fields to estate property. -Added the new fields to the view.

-created list view for estate property tag. -created menu to access estate property tags. -created a filed for tag ids in estate property. -Added the new field to estate property view.

-Added access rights to the model. -created list and form view to model. -Added offer ids field to estate property model, and added it to its view.

… field to evaluate its value. -Added the new field to the models form view.

… country. -Added the field to the model's form view.

-Added the action to a button in estate property view.

-Added access rights to public user. -Added read and write record rules to public user. -Added server action to return estate property list.

robodoo · 2025-06-06T15:26:52Z

vava-odoo

Good job. Please find a few remarks while going through your code. Hope it helps

vava-odoo · 2025-06-10T07:43:40Z

estate/data/estate_property.xml

+        <field name="name">x_user_id</field>
+        <field name="field_description">Salesperson</field>
+        <field name="ttype">many2one</field>
+        <field name="relation">res.partner</field>


Salesperson is a user, no?

vava-odoo · 2025-06-10T07:45:17Z

estate/data/estate_property.xml

+    </record>
+
+    <record id="field_estate_property_proprty_type_id" model="ir.model.fields">
+        <field name="model_id" ref="estate.model_estate_property" />


ref to an id of the same module works without having to specify the complete xmlid

Suggested change

<field name="model_id" ref="estate.model_estate_property" />

<field name="model_id" ref="model_estate_property" />

This is not true when dealing with env.ref

vava-odoo · 2025-06-10T07:46:39Z

estate/data/estate_property.xml

+        <field name="model_id" ref="estate.model_estate_property" />
+        <field name="name">x_total_area</field>
+        <field name="field_description">Total Area</field>
+        <field name="ttype">float</field>


Since both areas are integers, you may want to stick with integers

Suggested change

<field name="ttype">float</field>

<field name="ttype">integer</field>

vava-odoo · 2025-06-10T07:50:30Z

estate/data/estate_property_offer.xml

+for offer in records:
+    offer.write({'x_status': 'accepted'})
+    offer.x_property_id.write({'x_selling_price': offer.x_price, 'x_partner_id': offer.x_partner_id})
+    for rejected_offer in offer.x_property_id.x_property_offer_ids:
+        if rejected_offer != offer:
+            rejected_offer.write({'x_status': 'refused'})


Ok, but what if you accept two offers for the same property? It seems like only one will be accepted, but it is kind of magic, no? Shouldn't we take more care (and maybe raise in such cases)?

vava-odoo · 2025-06-10T07:51:54Z

estate/data/estate_property.xml

+
+    <record id="field_estate_property_api_published" model="ir.model.fields">
+        <field name="model_id" ref="estate.model_estate_property" />
+        <field name="name">x_api_published</field>


Did you find out how to set a default value for this field?

vava-odoo · 2025-06-10T07:54:15Z

estate/security/estate_security.xml

+        <field name="model_id" ref="model_estate_property"/>
+        <field name="domain_force">[('x_api_published','=',True)]</field>
+        <field name="groups" eval="[(4, ref('base.group_public'))]"/>
+        <field name="perm_read" eval="True"/>


By default the rule applies to all perm_* fields, so this one is not mandatory (and somehow misleading, because you are giving other rights too)

Suggested change

<field name="perm_read" eval="True"/>

vava-odoo · 2025-06-10T07:55:24Z

estate/static/src/js/tour.js

+
+
+registry.category("web_tour.tours").add('estate_tour', {
+    url: "/web",


url is now defined in the xml web_tour (and should point to /odoo). But since this is the default value, you don't have to :-)

Suggested change

url: "/web",

vava-odoo · 2025-06-10T07:55:43Z

estate/static/src/js/tour.js

+    url: "/web",
+    steps: () => [{
+    trigger: '.o_app[data-menu-xmlid="estate.menu_root"]',
+    content: 'Start selling your properties from this app!',


What if you want to translate the string here?

vava-odoo · 2025-06-10T07:56:59Z

estate/data/estate_tour.xml

@@ -0,0 +1,9 @@
+<?xml version="1.0" encoding="utf-8"?>
+
+<odoo>


User probably don't want this tour to show up anytime they upgrade, so setting this as noupdate seems appropriate

vava-odoo · 2025-06-10T07:59:11Z

estate/views/estate_property_views.xml

+                            <group>
+                                <field name="x_property_offer_ids"/>
+                            </group>


Probably better without a group here

Suggested change

<group>

<field name="x_property_offer_ids"/>

</group>

<field name="x_property_offer_ids"/>

vava-odoo · 2025-06-10T08:01:40Z

estate/data/estate_property.xml

+
+    <record id="field_estate_property_total_area" model="ir.model.fields">
+        <field name="model_id" ref="estate.model_estate_property" />
+        <field name="name">x_total_area</field>


Do you need to store that field?

abdrahmanrashed added 12 commits June 5, 2025 11:08

[ADD] -Created an importable estate module.

f37f7e8

[IMP] -Added estate property model with some basic fields.

a020848

[IMP] -Added access rights for the estate property model.

cbbf69f

[IMP] -added list and form views for estate model.

308ddb2

-added menus to access estate views from main menu.

[IMP] -Created estate property type model.

60c281c

-Added list view to estate property type. -Added menu to access estate property type. -Added access rights to estate property type. -Added some related fields to estate property. -Added the new fields to the view.

[IMP] -created estate property tag model.

6c1dc9a

-created list view for estate property tag. -created menu to access estate property tags. -created a filed for tag ids in estate property. -Added the new field to estate property view.

[IMP] -created estate property offer model.

3855227

-Added access rights to the model. -created list and form view to model. -Added offer ids field to estate property model, and added it to its view.

[IMP] -Added total area field to estate property model and a computed…

d70d365

… field to evaluate its value. -Added the new field to the models form view.

[IMP] -Added a related field in estate property model for the buyer's…

a9cb5f0

… country. -Added the field to the model's form view.

[IMP] -Added an action in estate property offer for accepting an offer.

6aa6dc0

-Added the action to a button in estate property view.

[IMP] -Added new API field to estate property model.

271bb4f

-Added access rights to public user. -Added read and write record rules to public user. -Added server action to return estate property list.

[IMP] -Added estate tour.

bf210ff

vava-odoo reviewed Jun 10, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

18.0 tutorial importable modules aras #811

18.0 tutorial importable modules aras #811

Uh oh!

abdrahmanrashed commented Jun 6, 2025

Uh oh!

robodoo commented Jun 6, 2025

Uh oh!

vava-odoo left a comment

Uh oh!

vava-odoo Jun 10, 2025

Uh oh!

vava-odoo Jun 10, 2025

Uh oh!

vava-odoo Jun 10, 2025

Uh oh!

vava-odoo Jun 10, 2025

Uh oh!

vava-odoo Jun 10, 2025

Uh oh!

vava-odoo Jun 10, 2025

Uh oh!

vava-odoo Jun 10, 2025

Uh oh!

vava-odoo Jun 10, 2025

Uh oh!

vava-odoo Jun 10, 2025

Uh oh!

vava-odoo Jun 10, 2025

Uh oh!

vava-odoo Jun 10, 2025

Uh oh!

Uh oh!

	<field name="model_id" ref="estate.model_estate_property" />
	<field name="model_id" ref="model_estate_property" />

	<field name="ttype">float</field>
	<field name="ttype">integer</field>



		registry.category("web_tour.tours").add('estate_tour', {
		url: "/web",

18.0 tutorial importable modules aras #811

Are you sure you want to change the base?

18.0 tutorial importable modules aras #811

Uh oh!

Conversation

abdrahmanrashed commented Jun 6, 2025

Uh oh!

robodoo commented Jun 6, 2025

Uh oh!

vava-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!