AttributeError: 'odoo.modules' has no attribute 'rename_module' when using odoo.upgrade.util.modules.rename_module

[Theyisuskill]

Environment:

• Odoo Version: [ 14.0, migrating to 18.0]
• upgrade-util Version: [If using a specific version/branch of upgrade-util or if it's the one bundled with your Odoo version]
• Python Version: [ 3.11]
• Operating System: [ Ubuntu 24.04,]
• • upgrade_path: [/home///odoo18/upgrade-util/src,] example

Problem Description:
I am attempting to use the rename_module function, which is expected to be available via odoo.upgrade.util.modules, within an Odoo migration script (def migrate(cr, version):).
I am importing util as from odoo.upgrade import util.

When calling util.modules.rename_module(cr, 'old_module_name', 'new_module_name'), an AttributeError is raised, indicating that the rename_module attribute is being sought on the standard odoo.modules module, not within odoo.upgrade.util.modules.

Steps to Reproduce:

1. Create a migration script (e.g., my_module/migrations/<version>/post_rename_module_script.py).
2. Add the following code to the script:

   import logging
   from odoo.upgrade import util # Or odoo.addons.upgrade.util if applicable
   
   _logger = logging.getLogger(__name__)
   
   def migrate(cr, version):
       old_module_name = 'l10n_account_SH' # Example old name
       new_module_name = 'l10n_account_sh' # Example new name
       
       _logger.info(f"Attempting to rename module '{old_module_name}' to '{new_module_name}' using odoo.upgrade.util...")
       try:
           # This is the line causing the error:
           util.modules.rename_module(cr, old_module_name, new_module_name)
           _logger.info(f"Module '{old_module_name}' successfully renamed to '{new_module_name}'.")
       except AttributeError as e:
           _logger.error(f"AttributeError encountered: {e}")
           # For debugging, you might want to see the full traceback
           # raise 
       except Exception as e:
           _logger.error(f"An unexpected error occurred: {e}")
           # raise

3. Run the Odoo upgrade process that triggers this migration script.

Expected Behavior:
The rename_module function from odoo.upgrade.util.modules should be successfully called, and the specified module should be renamed in the database.

Actual Behavior:
An AttributeError is raised:
AttributeError: module 'odoo.modules' has no attribute 'rename_module'

It appears that util.modules within the script is resolving to the Odoo's core odoo.modules (responsible for module registry, graph, etc.) instead of the modules submodule of odoo.upgrade.util.

Relevant Documentation:
The official upgrade-util documentation (or Odoo developer documentation for upgrades) suggests a structure like odoo.upgrade.util.modules.some_function(...). For instance, odoo.upgrade.util.modules.modules_installed(cr, *modules) is documented, implying that util.modules.FUNCTION_NAME should be a valid access pattern.

Additional Context/Questions:

• Is there a different import path or method to correctly access rename_module from odoo.upgrade.util.modules?
• Could there be a name collision or an issue with how odoo.upgrade.util exposes its modules submodule?
• The env = util.env(cr) call in the original script (from the screenshot) seems to work, which might suggest util itself is imported correctly, but its modules attribute is problematic.

Thank you for your time and assistance.

[aj-fuentes]

Do not use submodules ever. Always use the top-lovel util module. In your case util.rename_module.

[Theyisuskill]

Yes, but in the documentation it appears like this and it is a little confusing

[aj-fuentes]

We are aware of that and we are working in a way to fix the full name you see there such that we can avoid the confusion.

Thanks for reporting this. I'm closing the issue.