Add note to docs

hdelan · hdelan · commit 0a75eef5e149 · 2024-11-14T17:06:45.000Z
urCommandBufferFinalizeExp will return UR_RESULT_ERROR_INVALID_OPERATION
if the command buffer has already been finalized.
diff --git a/include/ur_api.h b/include/ur_api.h
@@ -8484,6 +8484,7 @@ urCommandBufferReleaseExp(
 ///     - ::UR_RESULT_ERROR_INVALID_NULL_HANDLE
 ///         + `NULL == hCommandBuffer`
 ///     - ::UR_RESULT_ERROR_INVALID_COMMAND_BUFFER_EXP
+///     - ::UR_RESULT_ERROR_INVALID_OPERATION - "If `hCommandBuffer` has already been finalized"
 ///     - ::UR_RESULT_ERROR_OUT_OF_HOST_MEMORY
 ///     - ::UR_RESULT_ERROR_OUT_OF_RESOURCES
 UR_APIEXPORT ur_result_t UR_APICALL
diff --git a/scripts/core/exp-command-buffer.yml b/scripts/core/exp-command-buffer.yml
@@ -330,6 +330,8 @@ params:
       desc: "[in] Handle of the command-buffer object."
 returns:
     - $X_RESULT_ERROR_INVALID_COMMAND_BUFFER_EXP
+    - $X_RESULT_ERROR_INVALID_OPERATION
+        - "If `hCommandBuffer` has already been finalized"
     - $X_RESULT_ERROR_OUT_OF_HOST_MEMORY
     - $X_RESULT_ERROR_OUT_OF_RESOURCES
 --- #--------------------------------------------------------------------------
diff --git a/source/loader/ur_libapi.cpp b/source/loader/ur_libapi.cpp
@@ -7542,6 +7542,7 @@ ur_result_t UR_APICALL urCommandBufferReleaseExp(
 ///     - ::UR_RESULT_ERROR_INVALID_NULL_HANDLE
 ///         + `NULL == hCommandBuffer`
 ///     - ::UR_RESULT_ERROR_INVALID_COMMAND_BUFFER_EXP
+///     - ::UR_RESULT_ERROR_INVALID_OPERATION - "If `hCommandBuffer` has already been finalized"
 ///     - ::UR_RESULT_ERROR_OUT_OF_HOST_MEMORY
 ///     - ::UR_RESULT_ERROR_OUT_OF_RESOURCES
 ur_result_t UR_APICALL urCommandBufferFinalizeExp(
diff --git a/source/ur_api.cpp b/source/ur_api.cpp
@@ -6405,6 +6405,7 @@ ur_result_t UR_APICALL urCommandBufferReleaseExp(
 ///     - ::UR_RESULT_ERROR_INVALID_NULL_HANDLE
 ///         + `NULL == hCommandBuffer`
 ///     - ::UR_RESULT_ERROR_INVALID_COMMAND_BUFFER_EXP
+///     - ::UR_RESULT_ERROR_INVALID_OPERATION - "If `hCommandBuffer` has already been finalized"
 ///     - ::UR_RESULT_ERROR_OUT_OF_HOST_MEMORY
 ///     - ::UR_RESULT_ERROR_OUT_OF_RESOURCES
 ur_result_t UR_APICALL urCommandBufferFinalizeExp(
diff --git a/test/conformance/exp_command_buffer/commands.cpp b/test/conformance/exp_command_buffer/commands.cpp
@@ -214,5 +214,4 @@ TEST_P(urCommandBufferAppendKernelLaunchExpTest, FinalizeTwice) {
     ASSERT_SUCCESS(urCommandBufferFinalizeExp(cmd_buf_handle));
     EXPECT_EQ_RESULT(urCommandBufferFinalizeExp(cmd_buf_handle),
                      UR_RESULT_ERROR_INVALID_OPERATION);
-
 }

Original file line number	Diff line number	Diff line change
`@@ -214,5 +214,4 @@ TEST_P(urCommandBufferAppendKernelLaunchExpTest, FinalizeTwice) {`
`214`	`214`	`ASSERT_SUCCESS(urCommandBufferFinalizeExp(cmd_buf_handle));`
`215`	`215`	`EXPECT_EQ_RESULT(urCommandBufferFinalizeExp(cmd_buf_handle),`
`216`	`216`	`UR_RESULT_ERROR_INVALID_OPERATION);`
`217`		`-`
`218`	`217`	`}`