Skip to content

[EXP][CMDBUF] HIP adapter support for command buffers #1254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 27, 2024

Conversation

mfrancepillois
Copy link
Contributor

  • command buffer functions for HIP.

  • Some additional methods and refactoring to reuse existing adapter code.
    (This code was mainly written by Andrey Alekseenko @al42and)

Co-authored-by: Andrey Alekseenko [email protected]

@mfrancepillois mfrancepillois requested review from a team as code owners January 16, 2024 12:11
@mfrancepillois
Copy link
Contributor Author

Liked DPC++ PR: intel/llvm#12230

@codecov-commenter
Copy link

codecov-commenter commented Jan 16, 2024

Codecov Report

Attention: Patch coverage is 0% with 34 lines in your changes are missing coverage. Please review.

Project coverage is 12.54%. Comparing base (78ef1ca) to head (a0bebf1).
Report is 55 commits behind head on main.

Files Patch % Lines
.../exp_command_buffer/buffer_saxpy_kernel_update.cpp 0.00% 28 Missing ⚠️
...e/exp_command_buffer/buffer_fill_kernel_update.cpp 0.00% 4 Missing ⚠️
test/conformance/exp_command_buffer/fixtures.h 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1254      +/-   ##
==========================================
- Coverage   14.82%   12.54%   -2.29%     
==========================================
  Files         250      239      -11     
  Lines       36220    35863     -357     
  Branches     4094     4067      -27     
==========================================
- Hits         5369     4498     -871     
- Misses      30800    31361     +561     
+ Partials       51        4      -47     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mfrancepillois
Copy link
Contributor Author

@jchlanda I've tried to address your comments as much as possible. Could you please take another look at this PR?

@EwanC EwanC added the ready to merge Added to PR's which are ready to merge label Jan 25, 2024
@mfrancepillois mfrancepillois requested a review from a team as a code owner February 19, 2024 09:53
@EwanC EwanC force-pushed the cmdbuf-support-hip branch from 90bd325 to c9d1431 Compare February 19, 2024 12:13
Copy link
Contributor

@aarongreig aarongreig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CTS changes LGTM

Command buffer functions for HIP.
Some additional methods and refactoring to reuse existing adapter code.

This code was mainly written by Andrey Alekseenko @al42and

Co-authored-by: Andrey Alekseenko [email protected]
Co-authored-by: Ewan Crawford <[email protected]>
@EwanC EwanC force-pushed the cmdbuf-support-hip branch from a0bebf1 to f78d369 Compare February 26, 2024 08:59
@kbenzie kbenzie merged commit a2757b2 into oneapi-src:main Feb 27, 2024
steffenlarsen pushed a commit to intel/llvm that referenced this pull request Mar 1, 2024
Tests HIP Support for Graph from
oneapi-src/unified-runtime#1254 and updates
documentation.

Depends on #12753.

---------

Co-authored-by: Andrey Alekseenko <[email protected]>
Co-authored-by: Ewan Crawford <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Added to PR's which are ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants