-
Notifications
You must be signed in to change notification settings - Fork 125
[EXP][CMDBUF] HIP adapter support for command buffers #1254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Liked DPC++ PR: intel/llvm#12230 |
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1254 +/- ##
==========================================
- Coverage 14.82% 12.54% -2.29%
==========================================
Files 250 239 -11
Lines 36220 35863 -357
Branches 4094 4067 -27
==========================================
- Hits 5369 4498 -871
- Misses 30800 31361 +561
+ Partials 51 4 -47 ☔ View full report in Codecov by Sentry. |
@jchlanda I've tried to address your comments as much as possible. Could you please take another look at this PR? |
90bd325
to
c9d1431
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CTS changes LGTM
Command buffer functions for HIP. Some additional methods and refactoring to reuse existing adapter code. This code was mainly written by Andrey Alekseenko @al42and Co-authored-by: Andrey Alekseenko [email protected] Co-authored-by: Ewan Crawford <[email protected]>
a0bebf1
to
f78d369
Compare
Tests HIP Support for Graph from oneapi-src/unified-runtime#1254 and updates documentation. Depends on #12753. --------- Co-authored-by: Andrey Alekseenko <[email protected]> Co-authored-by: Ewan Crawford <[email protected]>
command buffer functions for HIP.
Some additional methods and refactoring to reuse existing adapter code.
(This code was mainly written by Andrey Alekseenko @al42and)
Co-authored-by: Andrey Alekseenko [email protected]