[HIP][CUDA] Remove function prototypes from enqueue.hpp

[hdelan]

These func prototypes are not needed as funcs are defined in enqueue.cpp before they are used. Addresses #1326 (comment)

[hdelan]

intel/llvm#13072

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 12.43%. Comparing base (78ef1ca) to head (099c32c).
Report is 188 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1460      +/-   ##
==========================================
- Coverage   14.82%   12.43%   -2.40%     
==========================================
  Files         250      241       -9     
  Lines       36220    36242      +22     
  Branches     4094     4111      +17     
==========================================
- Hits         5369     4506     -863     
- Misses      30800    31732     +932     
+ Partials       51        4      -47     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[yingcong-wu]

Hi @hdelan , just to let you know that I would need them for my PR #1385. You can still remove them in this PR, and I can add them back later. I am fine with that.

[hdelan]

Hi @hdelan , just to let you know that I would need them for my PR #1385. You can still remove them in this PR, and I can add them back later. I am fine with that.

OK would it be better if I close this PR and you can change the prototype to the new version in #1385 ?

[yingcong-wu]

Sure, but I am not sure when my PR can be merged. If the wrong prototype will cause some problems, then I will suggest that we change it(or remove it now).

[hdelan]

Sure, but I am not sure when my PR can be merged. If the wrong prototype will cause some problems, then I will suggest that we change it(or remove it now).

OK sure I will keep this PR open

[kbenzie]

@hdelan is this a fix for #1326? If so it should probably have the v0.9.x label, is that correct?

[hdelan]

@hdelan is this a fix for #1326? If so it should probably have the v0.9.x label, is that correct?

Yes correct. The build isn't broken or anything but strictly speaking it should be merged ASAP

[kbenzie]

Is this causing this failure? If so I'll probably go ahead and merge this now.

[hdelan]

@kbenzie I don't believe the failures are related. I didn't see that in any of the CI for my merged patch nor have I seen it in other CI runs

[aarongreig]

ping @oneapi-src/unified-runtime-cuda-write @oneapi-src/unified-runtime-hip-write, this is slated for the release