Skip to content

[L0] Fix regular in order command list reuse given inorder queue #1483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

nrspruit
Copy link
Contributor

  • Fix command lists cache usage such that given an inorder queue and in order lists is requested, then only in order lists can be used from the cache.

@nrspruit nrspruit force-pushed the fix_inorder_lists_reuse branch from 05b2c46 to 082aede Compare March 28, 2024 21:17
- Fix command lists cache usage such that given an inorder queue and in
  order lists is requested, then only in order lists can be used from
the cache.

Signed-off-by: Neil R. Spruit <[email protected]>
@nrspruit nrspruit force-pushed the fix_inorder_lists_reuse branch from 082aede to e2e4472 Compare March 28, 2024 21:39
nrspruit added a commit to nrspruit/llvm that referenced this pull request Mar 28, 2024
Copy link
Contributor

@raiyanla raiyanla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now, assuming CI/tests all pass still.

@nrspruit nrspruit added level-zero L0 adapter specific issues ready to merge Added to PR's which are ready to merge v0.9.x Include in the v0.9.x release labels Mar 28, 2024
@nrspruit
Copy link
Contributor Author

This change is a blocker for #1370 which exposed this bug.

@aarongreig aarongreig merged commit 758c614 into oneapi-src:main Apr 10, 2024
martygrant pushed a commit to intel/llvm that referenced this pull request Apr 12, 2024
kbenzie pushed a commit to kbenzie/unified-runtime that referenced this pull request Apr 16, 2024
[L0] Fix regular in order command list reuse given inorder queue
@kbenzie kbenzie mentioned this pull request Apr 16, 2024
19 tasks
kbenzie pushed a commit that referenced this pull request Apr 17, 2024
[L0] Fix regular in order command list reuse given inorder queue
kbenzie pushed a commit to kbenzie/intel-llvm that referenced this pull request Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
level-zero L0 adapter specific issues ready to merge Added to PR's which are ready to merge v0.9.x Include in the v0.9.x release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants