-
Notifications
You must be signed in to change notification settings - Fork 125
[L0] Fix regular in order command list reuse given inorder queue #1483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nrspruit
commented
Mar 28, 2024
- Fix command lists cache usage such that given an inorder queue and in order lists is requested, then only in order lists can be used from the cache.
raiyanla
reviewed
Mar 28, 2024
05b2c46
to
082aede
Compare
- Fix command lists cache usage such that given an inorder queue and in order lists is requested, then only in order lists can be used from the cache. Signed-off-by: Neil R. Spruit <[email protected]>
082aede
to
e2e4472
Compare
nrspruit
added a commit
to nrspruit/llvm
that referenced
this pull request
Mar 28, 2024
pre-commit PR for oneapi-src/unified-runtime#1483 Signed-off-by: Neil R. Spruit <[email protected]>
raiyanla
approved these changes
Mar 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now, assuming CI/tests all pass still.
This change is a blocker for #1370 which exposed this bug. |
winstonzhang-intel
approved these changes
Apr 4, 2024
martygrant
pushed a commit
to intel/llvm
that referenced
this pull request
Apr 12, 2024
…13195) pre-commit PR for oneapi-src/unified-runtime#1483 --------- Signed-off-by: Neil R. Spruit <[email protected]> Co-authored-by: Aaron Greig <[email protected]>
kbenzie
pushed a commit
to kbenzie/unified-runtime
that referenced
this pull request
Apr 16, 2024
[L0] Fix regular in order command list reuse given inorder queue
19 tasks
kbenzie
pushed a commit
that referenced
this pull request
Apr 17, 2024
[L0] Fix regular in order command list reuse given inorder queue
kbenzie
pushed a commit
to kbenzie/intel-llvm
that referenced
this pull request
Apr 18, 2024
…ntel#13195) pre-commit PR for oneapi-src/unified-runtime#1483 --------- Signed-off-by: Neil R. Spruit <[email protected]> Co-authored-by: Aaron Greig <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
level-zero
L0 adapter specific issues
ready to merge
Added to PR's which are ready to merge
v0.9.x
Include in the v0.9.x release
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.