[L0][Image] Set ZeImageDesc member of _ur_image in release build for legacy image #1498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…legacy image This fix a regression intel/llvm#13090 caused by 8499b57 which adds ZeImageDesc member to _ur_image regardless of NDEBUG.
nrspruit
added a commit
to nrspruit/llvm
that referenced
this pull request
Apr 9, 2024
…for legacy image - reenable the image interop test with fix to image interop in release builds - precommit PR for oneapi-src/unified-runtime#1498 Signed-off-by: Neil R. Spruit <[email protected]>
|
Thank you @wenju-he , I have created a draft PR with your change along with the re-enable of the image test following your update. If this passes, then we should be able to merge this change along with enabling the test again. |
|
Your changes appear to be working now here: |
nrspruit
approved these changes
Apr 9, 2024
|
The failure in the CI is in the amd testing which is unrelated to this change. |
nrspruit
added
level-zero
Thank you @nrspruit |
martygrant
pushed a commit
to intel/llvm
that referenced
this pull request
Apr 15, 2024
#13338) …for legacy image - reenable the image interop test with fix to image interop in release builds - precommit PR for oneapi-src/unified-runtime#1498 --------- Signed-off-by: Neil R. Spruit <[email protected]> Co-authored-by: Aaron Greig <[email protected]>
kbenzie
pushed a commit
to kbenzie/unified-runtime
that referenced
this pull request
Apr 16, 2024
…geCreateWithNativeHandle [L0][Image] Set ZeImageDesc member of _ur_image in release build for legacy image
19 tasks
kbenzie
pushed a commit
that referenced
this pull request
Apr 17, 2024
…thNativeHandle [L0][Image] Set ZeImageDesc member of _ur_image in release build for legacy image
kbenzie
pushed a commit
to kbenzie/intel-llvm
that referenced
this pull request
Apr 18, 2024
intel#13338) …for legacy image - reenable the image interop test with fix to image interop in release builds - precommit PR for oneapi-src/unified-runtime#1498 --------- Signed-off-by: Neil R. Spruit <[email protected]> Co-authored-by: Aaron Greig <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix a regression intel/llvm#13090 caused by 8499b57 which adds ZeImageDesc member to _ur_image regardless of NDEBUG.